1. Home
  2. Development
  3. RE: theme upgrade not working in 7.2

RE: theme upgrade not working in 7.2

Vishnu S Kumar, modified 5 Years ago.
theme upgrade not working in 7.2
Regular Member Posts: 131 Join Date: 7/28/17 Recent Posts
I'm upgrading the Liferay theme from 7.1 to 7.2. I followed this documentation up to step 2. Step 3 fails as 'gulp upgrade' command throws the following exception. 
>gulp upgrade

fs.js:33
} = primordials;
    ^ReferenceError: primordials is not defined
    at fs.js:33:5
    at req_ (V:\test-projects\test\themes\test-theme\node_modules\natives\index.js:143:24)
    at Object.req [as require] (V:\test-projects\test\themes\test-theme\node_modules\natives\index.js:55:10)
    at Object.<anonymous> (V:\test-projects\test\themes\test-theme\node_modules\graceful-fs\fs.js:1:37)
    at Module._compile (internal/modules/cjs/loader.js:1128:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1167:10)
    at Module.load (internal/modules/cjs/loader.js:983:32)
    at Function.Module._load (internal/modules/cjs/loader.js:891:14)
    at Module.require (internal/modules/cjs/loader.js:1023:19)
    at require (internal/modules/cjs/helpers.js:72:18)

gulp version : CLI version: 2.2.0  , Local version: 3.9.1
node version: v13.3.0
thumbnail
Alfonso Crisci, modified 5 Years ago.
RE: theme upgrade not working in 7.2 (Answer)
Regular Member Posts: 136 Join Date: 4/2/14 Recent Posts
Hi Vishnu, this is likely the result of a gulp and node combination. I replied to this topic in the past:  https://liferay.dev/forums/-/message_boards/message/117746802/maximized#_com_liferay_message_boards_web_portlet_MBPortlet_message_117790975 but I can also add https://stackoverflow.com/questions/55921442/how-to-fix-referenceerror-primordials-is-not-defined-in-node and https://github.com/liferay/clay/issues/2053.
So either upgrading to gulp 4 or downgrading to an earlier node version should help.
Vishnu S Kumar, modified 5 Years ago.
RE: theme upgrade not working in 7.2 (Answer)
Regular Member Posts: 131 Join Date: 7/28/17 Recent Posts
Thank You. You're right. It has caused due to the node and gulp combination. However, upgrading gulp to v4 didn't work with any versions of the node. After a few experiments, I figured out the working combination. node v11.15.0 and gulp v3.9.1.
thumbnail
Alfonso Crisci, modified 5 Years ago.
RE: theme upgrade not working in 7.2
Regular Member Posts: 136 Join Date: 4/2/14 Recent Posts
Happy to know this is resolved and thanks for sharing an example of working combination, this will help fellow community members as well.