RE: New idea for Community VerifiersRE: New idea for Community Verifiershttps://liferay.dev/en/c/message_boards/find_thread?p_l_id=119785333&threadId=152553082024-03-29T00:08:55Z2024-03-29T00:08:55ZRE: New idea for Community VerifiersSampsa Sohlmanhttps://liferay.dev/en/c/message_boards/find_message?p_l_id=119785333&messageId=160580322012-09-03T12:45:08Z2012-09-03T12:45:08Z<div class="quote-title">Jorge Ferrer:</div><blockquote>Sampsa, it's more of an announcement than an in depth description of how we use it.</blockquote><br /><br />True, didn't give answers what I was looking for. <br /><br /><div class="quote-title">Jorge Ferrer:</div><blockquote> I'll think of writing a second blog entry about how we use GitHub later</blockquote><br /><br />I might wait for this, but it might be that I learn that earlier, little bit harder way <img alt="emoticon" src="@theme_images_path@/emoticons/happy.gif" ><br /><br /><div class="quote-title">Jorge Ferrer:</div><blockquote>, but I'd prefer to wait until we get rid of git-svn since it limits some of the capabilities of Git. Once we stop using it we'll probably change be able to use branches even more aggressively <img alt="emoticon" src="@theme_images_path@/emoticons/happy.gif" ></blockquote><br /><br />I think git give's better tools to automate development process than SVN and I'm eager to see what you have a mind <img alt="emoticon" src="@theme_images_path@/emoticons/happy.gif" >Sampsa Sohlman2012-09-03T12:45:08ZRE: New idea for Community VerifiersJorge Ferrerhttps://liferay.dev/en/c/message_boards/find_message?p_l_id=119785333&messageId=160158842012-08-31T10:33:20Z2012-08-31T10:33:20ZAs promised, I've finally been able to write the blog entry:<br /><a href="http://www.liferay.com/web/jorge.ferrer/blog/-/blogs/liferay-s-source-is-now-at-github-go-fork-it-">http://www.liferay.com/web/jorge.ferrer/blog/-/blogs/liferay-s-source-is-now-at-github-go-fork-it-</a><br /><br />Sampsa, it's more of an announcement than an in depth description of how we use it. I'll think of writing a second blog entry about how we use GitHub later, but I'd prefer to wait until we get rid of git-svn since it limits some of the capabilities of Git. Once we stop using it we'll probably change be able to use branches even more aggressively <img alt="emoticon" src="@theme_images_path@/emoticons/happy.gif" >Jorge Ferrer2012-08-31T10:33:20ZRE: New idea for Community VerifiersMika Koivistohttps://liferay.dev/en/c/message_boards/find_message?p_l_id=119785333&messageId=158947882012-08-27T18:43:34Z2012-08-27T18:43:34ZYeah, we do create a new branch for each ticket then send it to our peer reviewer who sends it to one of the master reviewer who have push rights to the liferay git account. In a way we are all just contributors.Mika Koivisto2012-08-27T18:43:34ZRE: New idea for Community VerifiersSampsa Sohlmanhttps://liferay.dev/en/c/message_boards/find_message?p_l_id=119785333&messageId=158321722012-08-24T06:59:41Z2012-08-24T06:59:41Z<div class="quote-title">Jorge Ferrer:</div><blockquote>I had been planning to write a blog entry about our move to GitHub</blockquote><br /><br />I think this would be good idea to describe your way to use git.<br /><br />I have impression that Liferay way of working with git is to create branch per issue and generate pull request from resulted changes. Currently this is not described at <a href="http://www.liferay.com/community/wiki/-/wiki/Main/Contribute+using+Git+and+GitHub">http://www.liferay.com/community/wiki/-/wiki/Main/Contribute+using+Git+and+GitHub</a> and would be good add on there too.Sampsa Sohlman2012-08-24T06:59:41ZRE: New idea for Community VerifiersJorge Ferrerhttps://liferay.dev/en/c/message_boards/find_message?p_l_id=119785333&messageId=158085102012-08-23T09:29:48Z2012-08-23T09:29:48ZHey Drew et al,<br /><br />This is an awesome idea, thanks so much.<br /><br />I had been planning to write a blog entry about our move to GitHub (which hasn't really been publicly announced) and explain how to contribute. This proposal comes just in time. I will be pointing people to the wiki pages and forum threads.<br /><br />Drew, it's very encouraging to have people like you in the community <img alt="emoticon" src="@theme_images_path@/emoticons/happy.gif" >Jorge Ferrer2012-08-23T09:29:48ZRE: New idea for Community VerifiersDrew Blessinghttps://liferay.dev/en/c/message_boards/find_message?p_l_id=119785333&messageId=157863012012-08-22T14:52:59Z2012-08-22T14:52:59ZAlright everyone. Everything is in place. If you're interested in helping out go ahead and find a ticket from this list <a href="http://issues.liferay.com/secure/Dashboard.jspa?selectPageId=13572">http://issues.liferay.com/secure/Dashboard.jspa?selectPageId=13572</a>. I think we'll find that many are easily resolved and won't take too much work. <br /><br />Don't be afraid to jump in! Just use the contribution guide James created here <a href="http://www.liferay.com/community/wiki/-/wiki/Main/Contribution+Processing+for+Community+Verifiers">http://www.liferay.com/community/wiki/-/wiki/Main/Contribution+Processing+for+Community+Verifiers</a>. Post back on this forum if you need help and we'll help you out.<br /><br />Thanks for your help!Drew Blessing2012-08-22T14:52:59ZRE: New idea for Community VerifiersJames Falknerhttps://liferay.dev/en/c/message_boards/find_message?p_l_id=119785333&messageId=157656722012-08-21T20:58:32Z2012-08-21T20:58:32Z<div class="quote-title">Drew Blessing:</div><blockquote>Thanks, James! That looks great. I'm working on the <a href="http://www.liferay.com/community/wiki/-/wiki/Main/Contribute+using+Git+and+GitHub">Contribute using Git and GitHub</a> wiki. I have a ways to go but I went ahead and published the first part so anyone else can begin to look at it and suggest changes.<br /><br />On a side note, I'm changing jobs next week so bear with me for a couple of weeks as I transition. Things will be crazy but I really want to get this program off the ground!</blockquote><br /><br />Hey Drew, I created <a href="http://www.liferay.com/community/wiki/-/wiki/Main/Community+Verifier+Contributors">another wiki page</a> to track community verifier activity. Hopefully our recruiting drive will help fill the board with our awesome community members! <img alt="emoticon" src="@theme_images_path@/emoticons/happy.gif" ><br /><br />Good luck in the new gig!James Falkner2012-08-21T20:58:32ZRE: New idea for Community VerifiersDrew Blessinghttps://liferay.dev/en/c/message_boards/find_message?p_l_id=119785333&messageId=156735642012-08-17T00:14:43Z2012-08-17T00:14:43ZThanks, James! That looks great. I'm working on the <a href="http://www.liferay.com/community/wiki/-/wiki/Main/Contribute+using+Git+and+GitHub">Contribute using Git and GitHub</a> wiki. I have a ways to go but I went ahead and published the first part so anyone else can begin to look at it and suggest changes.<br /><br />On a side note, I'm changing jobs next week so bear with me for a couple of weeks as I transition. Things will be crazy but I really want to get this program off the ground!Drew Blessing2012-08-17T00:14:43ZRE: New idea for Community VerifiersJames Falknerhttps://liferay.dev/en/c/message_boards/find_message?p_l_id=119785333&messageId=156713052012-08-16T20:54:09Z2012-08-16T20:54:09Z<div class="quote-title">Juan Fernández:</div><blockquote>We should link this page... it' quite cool! <img alt="emoticon" src="@theme_images_path@/emoticons/happy.gif" > <a href="http://www.liferay.com/de/community/wiki/-/wiki/Main/Getting+started+as+a+Liferay+Developer+in+a+few+steps">Getting started as a Liferay Developer in a few steps</a></blockquote><br /><br />Hey Drew et al,<br /><br />I created <a href="http://www.liferay.com/community/wiki/-/wiki/Main/Contribution+Processing+for+Community+Verifiers">this step-by-step guide for participating in this effort</a>. Please check it out and make edits as necessary (inserting links to the git-specific pages Drew is working on). I am going to start recruiting from the existing CVers and get some new ones hopefully <img alt="emoticon" src="@theme_images_path@/emoticons/happy.gif" > Cheers!James Falkner2012-08-16T20:54:09ZRE: New idea for Community VerifiersJuan Fernándezhttps://liferay.dev/en/c/message_boards/find_message?p_l_id=119785333&messageId=154536952012-08-08T11:12:36Z2012-08-08T11:12:36ZWe should link this page... it' quite cool! <img alt="emoticon" src="@theme_images_path@/emoticons/happy.gif" > <a href="http://www.liferay.com/de/community/wiki/-/wiki/Main/Getting+started+as+a+Liferay+Developer+in+a+few+steps">Getting started as a Liferay Developer in a few steps</a>Juan Fernández2012-08-08T11:12:36ZRE: New idea for Community VerifiersJames Falknerhttps://liferay.dev/en/c/message_boards/find_message?p_l_id=119785333&messageId=154286032012-08-07T16:25:50Z2012-08-07T16:25:50Z<div class="quote-title">Drew Blessing:</div><blockquote>I made a first attempt update to the Contributing wiki. <a href="http://www.liferay.com/community/wiki/-/wiki/Main/Contributing">http://www.liferay.com/community/wiki/-/wiki/Main/Contributing</a><br /><br />There are some other things I would like to add. First, I'd like to skim some of the information from this Liferay page and add to the wiki: <a href="http://www.liferay.com/community/welcome/contribute">http://www.liferay.com/community/welcome/contribute</a>. There's some really good stuff there. Also, I'd like to write/update a wiki page on using Git/GitHub to contribute code. There should also probably be some writing/updating of building Liferay from source, setting up Liferay IDE, etc. I know there are some of these out there but they are horribly old or slapped together with years of different information. <br /><br />As we go, I'd definitely appreciate any input you guys can give on the wikis. Some of this will be perspective only and I want to make sure it's as accurate and applicable to all as possible. Thanks!<br /><br />EDIT: I will also add the pieces Juan suggested above <img alt="emoticon" src="@theme_images_path@/emoticons/happy.gif" ></blockquote><br /><br />Drew, thanks for all your help getting the 'contributions' pages in order - it's sorely needed! And I wholeheartedly agree with Juan's sentiments re: git vs. svn vs. patch. As part of your program, I think CVers should <em>prefer</em> git if they know it, but not <em>require</em> it, when working with community contributors to get their existing contributions in order. Ultimately, any contribution will eventually need to go through git, so if that can happen earlier in the process, then great, but not if it means losing excitement and desire to participate <img alt="emoticon" src="@theme_images_path@/emoticons/happy.gif" > The git/github article will help with that. <a href="https://www.dnebinger.com/wiki/-/wiki/Setup+and+Configuration/Liferay+Contributor+Development+Environment+Setup">Dave has some content</a> you may borrow from, but he stopped short of explaining how to submit pull requests, etc <img alt="emoticon" src="@theme_images_path@/emoticons/happy.gif" >James Falkner2012-08-07T16:25:50ZRE: New idea for Community VerifiersDrew Blessinghttps://liferay.dev/en/c/message_boards/find_message?p_l_id=119785333&messageId=154046562012-08-07T03:58:40Z2012-08-07T03:58:40ZI made a first attempt update to the Contributing wiki. <a href="http://www.liferay.com/community/wiki/-/wiki/Main/Contributing">http://www.liferay.com/community/wiki/-/wiki/Main/Contributing</a><br /><br />There are some other things I would like to add. First, I'd like to skim some of the information from this Liferay page and add to the wiki: <a href="http://www.liferay.com/community/welcome/contribute">http://www.liferay.com/community/welcome/contribute</a>. There's some really good stuff there. Also, I'd like to write/update a wiki page on using Git/GitHub to contribute code. There should also probably be some writing/updating of building Liferay from source, setting up Liferay IDE, etc. I know there are some of these out there but they are horribly old or slapped together with years of different information. <br /><br />As we go, I'd definitely appreciate any input you guys can give on the wikis. Some of this will be perspective only and I want to make sure it's as accurate and applicable to all as possible. Thanks!<br /><br />EDIT: I will also add the pieces Juan suggested above <img alt="emoticon" src="@theme_images_path@/emoticons/happy.gif" >Drew Blessing2012-08-07T03:58:40ZRE: New idea for Community VerifiersDrew Blessinghttps://liferay.dev/en/c/message_boards/find_message?p_l_id=119785333&messageId=153811502012-08-06T11:58:59Z2012-08-06T11:58:59Z<div class="quote-title">Niko H:</div><blockquote>Nice, Think I'll be reading up on contributing <img alt="emoticon" src="@theme_images_path@/emoticons/happy.gif" ></blockquote><br /><br />I'm glad you're interested, Niko! Let us know if you have questions about CV and contributing. We'll get this new initiative off the ground soon.Drew Blessing2012-08-06T11:58:59ZRE: New idea for Community VerifiersDrew Blessinghttps://liferay.dev/en/c/message_boards/find_message?p_l_id=119785333&messageId=153811362012-08-06T11:58:09Z2012-08-06T11:58:09Z<div class="quote-title">Juan Fernández:</div><blockquote>The first goal here is to increase the number of contributions to the project, to make the contribution process easier for newcomers, and with that goal in mind the Git vs Patch fight is meaningless, do you agree?</blockquote><br /><br />Yes, that sounds good. Thanks!Drew Blessing2012-08-06T11:58:09ZRE: New idea for Community VerifiersJuan Fernándezhttps://liferay.dev/en/c/message_boards/find_message?p_l_id=119785333&messageId=153696542012-08-06T06:20:27Z2012-08-06T06:20:27Z<div class="quote-title">Drew Blessing:</div><blockquote>You mention patches attached to tickets - are you OK with this method of contribution? I thought maybe GIT was the sole method preferred now.</blockquote><br /><br />Hi Drew:<br />there's a lot of svn people around in the corporate world, and for them, if you force them to use another tool, you'll make them give up in the contribution process. GitHub is INFINITELY better for us to receive contributions and we should try educate the community members in how good it is to use git and how to use git by all means we have, but I don't want to FORCE them in case they don't know about Git. <br /><br />The first goal here is to increase the number of contributions to the project, to make the contribution process easier for newcomers, and with that goal in mind the Git vs Patch fight is meaningless, do you agree? After we have a good group of contributors, we can focus on increasing the "quality" of those contributors by moving them to Git<br /><br />Thanks for all your efforts, DrewJuan Fernández2012-08-06T06:20:27ZRE: New idea for Community VerifiersNiko Humalamäkihttps://liferay.dev/en/c/message_boards/find_message?p_l_id=119785333&messageId=153623642012-08-05T16:06:28Z2012-08-05T16:06:28ZNice, Think I'll be reading up on contributing <img alt="emoticon" src="@theme_images_path@/emoticons/happy.gif" >Niko Humalamäki2012-08-05T16:06:28ZRE: New idea for Community VerifiersDrew Blessinghttps://liferay.dev/en/c/message_boards/find_message?p_l_id=119785333&messageId=153245972012-08-03T13:18:22Z2012-08-03T13:18:22Z<div class="quote-title">Juan Fernández:</div><blockquote>Hi Drew:<br />instead of writing a new wiki article, why don't we extend this one? [<a href="http://www.liferay.com/community/wiki/-/wiki/Main/Contributing">Contributing</a>]<br /></blockquote><br /><br />That's definitely a good idea! I will work with James to get this updated. You mention patches attached to tickets - are you OK with this method of contribution? I thought maybe GIT was the sole method preferred now.Drew Blessing2012-08-03T13:18:22ZRE: New idea for Community VerifiersJuan Fernándezhttps://liferay.dev/en/c/message_boards/find_message?p_l_id=119785333&messageId=153102192012-08-03T06:38:25Z2012-08-03T06:38:25ZHi Drew:<br />instead of writing a new wiki article, why don't we extend this one? [<a href="http://www.liferay.com/community/wiki/-/wiki/Main/Contributing">Contributing</a>]<br />When you go to liferay.com - community - contribute it brings you to that article, so I think we should improve it A LOT. <br />Things we can add there:<br /><ul><li>Say that there are two ways: patches or GIT pull-requests</li><li>Link to article explaining how to get the latest code base</li><li>Link to article explaining how to build trunk in different IDEs</li><li>Link to the list of module owners, so that they know who to ping</li></ul><br /><br />Thanks!Juan Fernández2012-08-03T06:38:25ZRE: New idea for Community Verifiers