1. Home
  2. Development
  3. RE: RE: Custom JSP Bags override method does not work

RE: RE: Custom JSP Bags override method does not work

Nikita Laitinen, modified 3 Years ago.
Custom JSP Bags override method does not work
Junior Member Posts: 44 Join Date: 12/18/19 Recent Posts

Hi

I'm doing liferay upgrade to 7.4 version
Need to override some core liferay jsps (docroot -> html -> common -> themes). I use custom jsp bag way to do it. https://help.liferay.com/hc/en-us/articles/360029122491-JSP-Overrides-Using-Custom-JSP-Bag
I updated dependencies, built module, deployed it, console says ok, gogo shell says ok it is active as well, but nothing changes I mean liferays jsps are not overriden.
What can cause this problem? Help please

7.4.2 ga3 - does not work
7.4.3.8-ga8 - does not work
7.3.5-ga6 - WORK

I guess the same problem is here https://liferay.dev/web/guest/forums-redirect/-/message_boards/message/88783349#_com_liferay_message_boards_web_portlet_MBPortlet_message_90559814

module framework (osgi)
thumbnail
Russell Bohl, modified 3 Years ago.
RE: Custom JSP Bags override method does not work
Expert Posts: 308 Join Date: 2/13/13 Recent Posts

I can't find any internal ticket about Custom JSP Bag implementations not working in 7.4. So let's assume it should work for now.

One idea: did the JSP path change? Which JSP are you trying to override?

Nikita Laitinen, modified 3 Years ago.
RE: RE: Custom JSP Bags override method does not work
Junior Member Posts: 44 Join Date: 12/18/19 Recent Posts

Hi
Thanks for reply
Nope, the path is the same.
I'm trying to override a couple of jsps, all of them are placed inside docroot -> html -> common -> themes

  • body_top.jsp
  • bottom_js.jspf
  • bottom.jsp
  • init.jsp
  • top_head.jsp
  • top_js.jspf
  • top_meta.jspf
thumbnail
Russell Bohl, modified 3 Years ago.
RE: RE: Custom JSP Bags override method does not work
Expert Posts: 308 Join Date: 2/13/13 Recent Posts

I've found this recently reported bug: LPS-146288

That may be the issue. Let's follow it and see what comes of it.

Nikita Laitinen, modified 3 Years ago.
RE: RE: Custom JSP Bags override method does not work
Junior Member Posts: 44 Join Date: 12/18/19 Recent Posts

I've found this recently reported bug: LPS-146288

Thank you!
I hope this is the reason of my problem and the solution will be found soon 

thumbnail
Nikita Laitinen, modified 3 Years ago.
RE: Custom JSP Bags override method does not work (Answer)
Expert Posts: 308 Join Date: 2/13/13 Recent Posts

LPS-146288 has not been solved, but another ticket, LPS-142278, has been fixed in Liferay 7.4 GA10. Can you try your Custom JSP Bag on GA10 and let me know if it worked? I will try to test one this week but if you have an impl handy it will be faster for you to check.

Nikita Laitinen, modified 3 Years ago.
RE: Custom JSP Bags override method does not work
Junior Member Posts: 44 Join Date: 12/18/19 Recent Posts

Hi
The CE 7.4 GA10 works. I did a quick test with one file and it seems to be working

thumbnail
Russell Bohl, modified 3 Years ago.
RE: RE: Custom JSP Bags override method does not work
Expert Posts: 308 Join Date: 2/13/13 Recent Posts

Great! glad to hear it's working.

Nikita Laitinen, modified 3 Years ago.
RE: Custom JSP Bags override method does not work (Answer)
Junior Member Posts: 44 Join Date: 12/18/19 Recent Posts

yep

Btw
Do you know something about this issue?? https://liferay.dev/web/guest/forums-redirect/-/message_boards/message/121356882

thumbnail
Russell Bohl, modified 3 Years ago.
RE: RE: Custom JSP Bags override method does not work
Expert Posts: 308 Join Date: 2/13/13 Recent Posts

I don't know about it--however, yesterday I did file a documentation ticket about it here. The writer who will pick up that docs ticket is going to speak with the team that owns Web Content to ask about it. That will reveal if it's an intended change or a bug. It may be due to an underlying framework change in the Structures backend, but it's too early to tell.