1. Home
  2. Development
  3. RE: Kick-starting from Classic theme in version 7.2 - missing dependency

RE: Kick-starting from Classic theme in version 7.2 - missing dependency

Jan Kadlec, modified 6 Years ago.
Kick-starting from Classic theme in version 7.2 - missing dependency
New Member Posts: 14 Join Date: 7/22/14 Recent Posts
Hi,
I am creating a theme which is based on styled theme, but I kick-started from the Classic theme version 7.2, basically by copying Classic theme files manually into my project.

Now the problem is that in the 7.2 Classic theme -> clay.scss file, there are 2 imports that fail during theme build (maven):

@import 'liferay-font-awesome/scss/font-awesome';
@import 'liferay-font-awesome/scss/glyphicons';

These 2 files are missing. It can be solved by removing the imports, but I guess that it's not right. How to solve this better?
thumbnail
David H Nebinger, modified 6 Years ago.
RE: Kick-starting from Classic theme in version 7.2 - missing dependency
Liferay Legend Posts: 14933 Join Date: 9/2/06 Recent Posts
I believe, although I may be wrong, that these files are created during the build itself.

You may need to actually do a build of the Liferay 7.2 source to get these files created for you.
Jan Kadlec, modified 6 Years ago.
RE: Kick-starting from Classic theme in version 7.2 - missing dependency
New Member Posts: 14 Join Date: 7/22/14 Recent Posts
Hi David,
that's what I thought as well - that these files should be created during the build - most probably downloaded. Which would mean there's some problem during the build. 
Jan Kadlec, modified 6 Years ago.
RE: Kick-starting from Classic theme in version 7.2 - missing dependency
New Member Posts: 14 Join Date: 7/22/14 Recent Posts
I just found this issue on GitHub that mentions this problem.

https://github.com/liferay/liferay-js-themes-toolkit/issues/380

Seems that it's been fixed for the node.js theme generator. But in IntelliJ IDEA Liferay plugin, the build still doesn't work. Does anyone know if it's going to be fixed, or is there a manual workaround?
thumbnail
David H Nebinger, modified 6 Years ago.
RE: Kick-starting from Classic theme in version 7.2 - missing dependency
Liferay Legend Posts: 14933 Join Date: 9/2/06 Recent Posts
I'm sure it will get addressed, but I can't say for certain when that might be.
Lee Jordan, modified 6 Years ago.
RE: Kick-starting from Classic theme in version 7.2 - missing dependency
Expert Posts: 449 Join Date: 5/26/15 Recent Posts
What happened to the theme generator ??? Is it still a thing?
Lee Jordan, modified 6 Years ago.
RE: Kick-starting from Classic theme in version 7.2 - missing dependency
Expert Posts: 449 Join Date: 5/26/15 Recent Posts

@import 'liferay-font-awesome/scss/font-awesome';
@import 'liferay-font-awesome/scss/glyphicons';

These 2 files are missing. It can be solved by removing the imports, but I guess that it's not right. How to solve this better?
As far as I know, Liferray pulled Font Awesome and Glyph from Classic?? Which reeeeeeeeealllllllly suuuuuuuuuuuuuucks, because we have to put it back ourselves.
thumbnail
Juan Gonzalez, modified 5 Years ago.
RE: Kick-starting from Classic theme in version 7.2 - missing dependency
Liferay Legend Posts: 3089 Join Date: 10/28/08 Recent Posts
Lee Jordan:


@import 'liferay-font-awesome/scss/font-awesome';
@import 'liferay-font-awesome/scss/glyphicons';

These 2 files are missing. It can be solved by removing the imports, but I guess that it's not right. How to solve this better?
As far as I know, Liferray pulled Font Awesome and Glyph from Classic?? Which reeeeeeeeealllllllly suuuuuuuuuuuuuucks, because we have to put it back ourselves.



Do you know where are them to put them back?
thumbnail
David H Nebinger, modified 5 Years ago.
RE: Kick-starting from Classic theme in version 7.2 - missing dependency
Liferay Legend Posts: 14933 Join Date: 9/2/06 Recent Posts
Liferay deprecated FA and Glyphs in lieu of the Clay icon support that is built in. If you can, I'd suggest using the Clay icons to shrink your dependencies/download sizes and enforce consistency w/ Liferay UI.
thumbnail
Juan Gonzalez, modified 5 Years ago.
RE: Kick-starting from Classic theme in version 7.2 - missing dependency
Liferay Legend Posts: 3089 Join Date: 10/28/08 Recent Posts
David H Nebinger:

Liferay deprecated FA and Glyphs in lieu of the Clay icon support that is built in. If you can, I'd suggest using the Clay icons to shrink your dependencies/download sizes and enforce consistency w/ Liferay UI.
Thanks David. Problem is I can't create a theme (using Maven) that imports "liferay-font-awesome". I see it was a bug (fixed here https://github.com/liferay/liferay-js-themes-toolkit/issues/380 ) but I wanted to fix it using Maven, not using the npm stuff.