Jorge Díaz 4 Years Ago Hi Michael Chen, Instead of writing this blog post or sending a pull request, it is better to create a bug issue in https://issues.liferay.com You have also information about how to contribute here: https://github.com/liferay/liferay-portal/blob/master/CONTRIBUTING.markdown Please sign in to reply. Reply as... Cancel Michael Chen Jorge Díaz 4 Years Ago - Edited Some may not consider this a bug. It's more like declaring a Java parameter final to prevent its value being changed. It's nice to have but not a must. But thanks for the suggestion. The more important point is for Liferay to acknowledge this and inform developers. Please sign in to reply. Reply as... Cancel
Michael Chen Jorge Díaz 4 Years Ago - Edited Some may not consider this a bug. It's more like declaring a Java parameter final to prevent its value being changed. It's nice to have but not a must. But thanks for the suggestion. The more important point is for Liferay to acknowledge this and inform developers. Please sign in to reply. Reply as... Cancel
Javier Moral 4 Years Ago Hi Michael Chen, Since https://issues.liferay.com/browse/LPS-104523 kaleo nodes are walked in a single thread so I think it might address at least some of your concerns Please sign in to reply. Reply as... Cancel Michael Chen Javier Moral 4 Years Ago - Edited Hi Javier, LPS-104523 consumes one KALEO_GRAPH_WALKER message payload in one thread, but what about the producer(s)? Will similar Kaloe messages be produced in quick successions, creating a scenario that cannot be solved by LPS-104523? For example, wouldn't parallel tasks in sibling fork paths produce independent messages? Also, what about other code that writes to KaleoInstance, like DefaultWorkflowEngineImpl, which competes with PathElementMessageListener? Thanks --Michael Please sign in to reply. Reply as... Cancel
Michael Chen Javier Moral 4 Years Ago - Edited Hi Javier, LPS-104523 consumes one KALEO_GRAPH_WALKER message payload in one thread, but what about the producer(s)? Will similar Kaloe messages be produced in quick successions, creating a scenario that cannot be solved by LPS-104523? For example, wouldn't parallel tasks in sibling fork paths produce independent messages? Also, what about other code that writes to KaleoInstance, like DefaultWorkflowEngineImpl, which competes with PathElementMessageListener? Thanks --Michael Please sign in to reply. Reply as... Cancel