Blogs

Hi Arun,

we tested 6.2.5-cumulative and created a patch to get Facebook Connect to work. The patch draws on replies to my post https://liferay.dev/forums/-/message_boards/message/87677757 and the workaround I had developed for that. The patch addresses two issues: HttpUtil  calls HTTPS URLs as HTTP only; Facebook has changed the Facebook Connect API.

Tests of 6.2.5-cumulative  with our patch applied are all positive. We will put that version into production.

If you added our patch into 6.2.5-cumulative we will gladly retest that version.

Thanks for your substantial help and quick responses,

Johannes

----------------------------------------------------------------------------------------------------------------------------

From aead75af36aebc5e02e37ee40fe2c415c9be7759 Mon Sep 17 00:00:00 2001 From: Johannes Feulner <johannes.feulner@scorio.com> Date: Tue, 28 Apr 2020 10:59:29 +0200 Subject: [PATCH 2/2] Fixed HTTPImpl.java for calling HTTPS URls; Fixed  FacebookConnect.java for current API

---  .../com/liferay/portal/facebook/FacebookConnectImpl.java  | 15 ++++++++++++++-  portal-impl/src/com/liferay/portal/util/HttpImpl.java     |  2 +-  2 files changed, 15 insertions(+), 2 deletions(-)

diff --git a/portal-impl/src/com/liferay/portal/facebook/FacebookConnectImpl.java b/portal-impl/src/com/liferay/portal/facebook/FacebookConnectImpl.java index e52e418..1192a0b 100644 --- a/portal-impl/src/com/liferay/portal/facebook/FacebookConnectImpl.java +++ b/portal-impl/src/com/liferay/portal/facebook/FacebookConnectImpl.java @@ -74,6 +74,7 @@ public class FacebookConnectImpl implements FacebookConnect {                         String content = HttpUtil.URLtoString(options);

                        if (Validator.isNotNull(content)) { +                               /* Facebook Connect API pre 2.3                                 int x = content.indexOf("access_token=");

                                if (x >= 0) { @@ -84,7 +85,19 @@ public class FacebookConnectImpl implements FacebookConnect {                                         }

                                        return content.substring(x + 13, y); -                               } +                               } */ + +                               /* [Oauth Access Token] Format according to Facebook +                                * The response format of +                                * https://www.facebook.com/v2.3/oauth/access_token returned +                                *  when you exchange a code for an access_token now return +                                *  valid JSON instead of being URL encoded. The new format +                                *  of this response is {"access_token": {TOKEN}, +                                *  "token_type":{TYPE}, "expires_in":{TIME}}. We made this +                                *  update to be compliant with section 5.1 of RFC 6749. +                                */ +                               String accessToken = JSONFactoryUtil.createJSONObject(content).getString("access_token"); +                               return accessToken;                         }                 }                 catch (Exception e) { diff --git a/portal-impl/src/com/liferay/portal/util/HttpImpl.java b/portal-impl/src/com/liferay/portal/util/HttpImpl.java index 0e1c824..ad81018 100644 --- a/portal-impl/src/com/liferay/portal/util/HttpImpl.java +++ b/portal-impl/src/com/liferay/portal/util/HttpImpl.java @@ -1609,7 +1609,7 @@ public class HttpImpl implements Http {                         _cookies.set(null);

                        HttpHost targetHttpHost = new HttpHost( -                               uri.getHost(), uri.getPort()); +                               uri.getHost(), uri.getPort(), uri.getScheme());

                        RequestConfig.Builder requestConfigBuilder =                                 getRequestConfigBuilder(uri, timeout); -- 2.7.4