RE: Help contacting the developers of the NODE gradle plugin

Larry Streepy, modified 6 Years ago. New Member Posts: 7 Join Date: 3/13/19 Recent Posts
I have had no responses to my requst for a fix to the NODE gradle plugin.  So, maybe someone can get me in contact with the developers of that plugin directly?  Or, forward this request to them?

I have had no success in any search to try and find a way to contact the developers, so these forums seem like the only option.

Thanks,
​​​​​​​Larry.
thumbnail
David H Nebinger, modified 6 Years ago. Liferay Legend Posts: 14933 Join Date: 9/2/06 Recent Posts
what node gradle plugin?
thumbnail
Christoph Rabel, modified 6 Years ago. Liferay Legend Posts: 1555 Join Date: 9/24/09 Recent Posts
I guess, this one:
https://dev.liferay.com/en/develop/reference/-/knowledge_base/7-0/node-gradle-plugin
thumbnail
David H Nebinger, modified 6 Years ago. Liferay Legend Posts: 14933 Join Date: 9/2/06 Recent Posts
If it is them, those guys are really busy (I know them).

​​​​​​​Perhaps the OP could raise his issue here so we could talk about it rather than how to contact them...
Larry Streepy, modified 6 Years ago. New Member Posts: 7 Join Date: 3/13/19 Recent Posts
Sorry to be dense, but when you say "raise his issue here" - exactly where (what forum) do I need to post?

Thanks,
​​​​​​​Larry.
thumbnail
Christoph Rabel, modified 6 Years ago. Liferay Legend Posts: 1555 Join Date: 9/24/09 Recent Posts
I think, you should just post your concerns here in this thread.
thumbnail
David H Nebinger, modified 6 Years ago. Liferay Legend Posts: 14933 Join Date: 9/2/06 Recent Posts
Yeah, sorry, just ask away.

If we don't have an answer, we can probably find someone who does.
Larry Streepy, modified 6 Years ago. New Member Posts: 7 Join Date: 3/13/19 Recent Posts
The current Node gradle plugin uses a deprecated method (Task.deleteAllActions) which has been removed in gradle 5.x.  We are trying to upgrade our development tool chain and the Node plugin's use of this method prevents us from doing so.  Can the plugin be upgraded to be compatible with gradle 5.x?

Thanks,
​​​​​​​Larry.
thumbnail
David H Nebinger, modified 6 Years ago. Liferay Legend Posts: 14933 Join Date: 9/2/06 Recent Posts
I'm sure it is on the roadmap, but I don't know when it will happen...

The team is in the midst of the 7.2 release finalization and I don't expect they'd want to introduce changes at this point for a gradle upgrade.

Also the Liferay Gradle workspace specifically uses the gradle wrapper so the right version of gradle is pulled for the workspace build; it's intended to make the build work regardless what your organization might be doing from a gradle version perspective.

I'll ping the team though to see where this fits on their roadmap and when it might be looked at...
Larry Streepy, modified 6 Years ago. New Member Posts: 7 Join Date: 3/13/19 Recent Posts
It's been a few weeks and I was wondering if there was any progress on this?
thumbnail
David Truong, modified 6 Years ago. Expert Posts: 322 Join Date: 3/24/05 Recent Posts
Larry StreepyIt's been a few weeks and I was wondering if there was any progress on this?

Hi Larry,

You are correct that we use a number of deprecated APIs that have been removed in Gradle 5.x.  We have plans to update our gradle version to 5.x in the second half of this year but it will be a significant undertaking.

If you do not need the node plugin, I would suggest possibly seeing if you can disable it from the tool chain to allow you to continue.  If you do need it, we would gladly accept a pull request if you manage to update the current node plugin to use an updated API.

Thanks,
David
Larry Streepy, modified 6 Years ago. New Member Posts: 7 Join Date: 3/13/19 Recent Posts
Hi David, we do use the plugin in our build, so not using it isn't an option (unless we go looking for another Node plugin).

I took a quick look at the code in question, and I can't figure out why the method is being called in the first place (unless there is some way that arbitrary actions are potentially being added more than once).  If there's a way to talk with a developer that knows that code, I would be happy to try and work up a Pull Request that reworks it.

Thanks,
Larry.